Skip to content

Commit 0c41305

Browse files
Improve example version instructions. Add info about "lts" if user specifies 1.6 explicitly (#265)
* improve example versions and note * add info if user explicitly sets version to 1.6 * npm run build * add 1.6 explicitly to CI * convert to a github actions notice * try core.notice * npm run build * Apply suggestions from code review Co-authored-by: Dilum Aluthge <[email protected]> * Update action.yml * update example * update toc * npm build --------- Co-authored-by: Dilum Aluthge <[email protected]>
1 parent 5956f5e commit 0c41305

File tree

5 files changed

+29
-14
lines changed

5 files changed

+29
-14
lines changed

.github/workflows/example-builds.yml

+2-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,8 @@ jobs:
1919
strategy:
2020
fail-fast: false
2121
matrix:
22-
julia-version: ['1.0.5', '1.2', '^1.5.0-beta1', '1', 'lts', 'pre']
22+
# include '1.6' here to test info message about lts tag existing
23+
julia-version: ['1.0.5', '1.2', '^1.5.0-beta1', '1', '1.6', 'lts', 'pre']
2324
julia-arch: [x64, x86]
2425
os: [ubuntu-latest, macOS-latest, windows-latest]
2526
# 32-bit Julia binaries are not available on macOS

README.md

+20-12
Original file line numberDiff line numberDiff line change
@@ -5,17 +5,25 @@
55
This action sets up a Julia environment for use in actions by downloading a specified version of Julia and adding it to PATH.
66

77
## Table of Contents
8-
- [Table of Contents](#table-of-contents)
9-
- [Usage](#usage)
10-
- [Inputs](#inputs)
11-
- [Outputs](#outputs)
12-
- [Basic](#basic)
13-
- [Julia Versions](#julia-versions)
14-
- [Matrix Testing](#matrix-testing)
15-
- [versioninfo](#versioninfo)
16-
- [Versioning](#versioning)
17-
- [Debug logs](#debug-logs)
18-
- [Third party information](#third-party-information)
8+
- [setup-julia Action](#setup-julia-action)
9+
- [Table of Contents](#table-of-contents)
10+
- [Usage](#usage)
11+
- [Inputs](#inputs)
12+
- [Outputs](#outputs)
13+
- [Basic](#basic)
14+
- [Julia Versions](#julia-versions)
15+
- [Examples](#examples)
16+
- [Prereleases](#prereleases)
17+
- [Recently released versions](#recently-released-versions)
18+
- [Matrix Testing](#matrix-testing)
19+
- [64-bit Julia only](#64-bit-julia-only)
20+
- [32-bit Julia](#32-bit-julia)
21+
- [versioninfo](#versioninfo)
22+
- [Versioning](#versioning)
23+
- [Using Dependabot version updates to keep your GitHub Actions up to date](#using-dependabot-version-updates-to-keep-your-github-actions-up-to-date)
24+
- [Debug logs](#debug-logs)
25+
- [Third party information](#third-party-information)
26+
- [Contributing to this repo](#contributing-to-this-repo)
1927

2028
## Usage
2129

@@ -30,7 +38,7 @@ This action sets up a Julia environment for use in actions by downloading a spec
3038
# Warning: It is strongly recommended to wrap this value in quotes.
3139
# Otherwise, the YAML parser used by GitHub Actions parses certain
3240
# versions as numbers which causes the wrong version to be selected.
33-
# For example, `1.0` may be parsed as `1`.
41+
# For example, `1.10` may be parsed as `1.1`.
3442
#
3543
# Default: '1'
3644
version: ''

action.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ description: 'Setup a Julia environment and add it to the PATH'
33
author: 'Sascha Mann'
44
inputs:
55
version:
6-
description: 'The Julia version to download (if necessary) and use. Example: 1.0.4'
6+
description: 'The Julia version to download (if necessary) and use. Use a string input to avoid unwanted decimal conversion e.g. 1.10 without quotes will be interpreted as 1.1. Examples: "1", "1.10", "lts", "pre"'
77
default: '1'
88
include-all-prereleases:
99
description: 'Include prereleases when matching the Julia version to available versions.'

lib/setup-julia.js

+3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/setup-julia.ts

+3
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,9 @@ async function run() {
5353
if (!versionInput) { // if `versionInput` is an empty string
5454
throw new Error('Version input must not be null')
5555
}
56+
if (versionInput == '1.6') {
57+
core.notice('[setup-julia] If you are testing 1.6 as a Long Term Support (lts) version, consider using the new "lts" version specifier instead of "1.6" explicitly, which will automatically resolve the current lts.')
58+
}
5659
if (!originalArchInput) { // if `originalArchInput` is an empty string
5760
throw new Error(`Arch input must not be null`)
5861
}

0 commit comments

Comments
 (0)