fix(agents-api): fix handeling settings as None in prompt_step

Ahmad-mtos · Ahmad-mtos · commit d6db94759f52 · 2025-01-02T19:10:43.000+03:00
diff --git a/agents-api/agents_api/activities/task_steps/prompt_step.py b/agents-api/agents_api/activities/task_steps/prompt_step.py
@@ -116,7 +116,7 @@ async def prompt_step(context: StepContext) -> StepOutcome:
     passed_settings: dict = context.current_step.model_dump(
         exclude=excluded_keys, exclude_unset=True
     )
-    passed_settings.update(passed_settings.pop("settings", {}))
+    passed_settings.update(passed_settings.pop("settings", {}) or {})
 
     if not passed_settings.get("tools"):
         passed_settings.pop("tool_choice", None)

Original file line number	Diff line number	Diff line change
`@@ -116,7 +116,7 @@ async def prompt_step(context: StepContext) -> StepOutcome:`
`116`	`116`	`passed_settings: dict = context.current_step.model_dump(`
`117`	`117`	`exclude=excluded_keys, exclude_unset=True`
`118`	`118`	`)`
`119`		`- passed_settings.update(passed_settings.pop("settings", {}))`
	`119`	`+ passed_settings.update(passed_settings.pop("settings", {}) or {})`
`120`	`120`
`121`	`121`	`if not passed_settings.get("tools"):`
`122`	`122`	`passed_settings.pop("tool_choice", None)`