Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add_unit needs a timeout #113

Open
dpb1 opened this issue Feb 9, 2016 · 2 comments
Open

add_unit needs a timeout #113

dpb1 opened this issue Feb 9, 2016 · 2 comments

Comments

@dpb1
Copy link
Contributor

dpb1 commented Feb 9, 2016

00:54:26.592 Traceback (most recent call last):
00:54:26.592 File "/usr/lib/python3/dist-packages/zope/testrunner/runner.py", line 400, in run_layer
00:54:26.592 setup_layer(options, layer, setup_layers)
00:54:26.592 File "/usr/lib/python3/dist-packages/zope/testrunner/runner.py", line 713, in setup_layer
00:54:26.592 layer.setUp()
00:54:26.592 File "/var/jenkins/workspace/charm-your-own-adventure/tests/layers.py", line 68, in setUp
00:54:26.592 cls.environment.set_unit_count("landscape-server", 2)
00:54:26.592 File "/var/jenkins/workspace/charm-your-own-adventure/tests/helpers.py", line 370, in set_unit_count
00:54:26.592 self._deployment.add_unit(service)
00:54:26.592 File "/usr/lib/python3/dist-packages/amulet/deployer.py", line 182, in add_unit
00:54:26.592 self.sentry = Talisman(self.services)
00:54:26.592 File "/usr/lib/python3/dist-packages/amulet/sentry.py", line 202, in init
00:54:26.592 status = self.wait_for_status(self.juju_env, services, timeout)
00:54:26.592 File "/usr/lib/python3/dist-packages/amulet/sentry.py", line 344, in wait_for_status
00:54:26.592 for i in helpers.timeout_gen(timeout):
00:54:26.592 File "/usr/lib/python3/dist-packages/amulet/helpers.py", line 108, in timeout_gen
00:54:26.592 raise TimeoutError()
00:54:26.592 amulet.helpers.TimeoutError

The add_unit in deployer.py should take an optional timeout which is passed along to Talisman(self.services)

As it is, there is no way to adjust for slower running charms/tests/clouds, etc.

@dpb1
Copy link
Contributor Author

dpb1 commented Feb 9, 2016

#114

@arosales
Copy link
Contributor

#114 merged, and queued up for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants