Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile error with [email protected] #5290

Closed
rafalste opened this issue Nov 12, 2024 · 3 comments
Closed

Compile error with [email protected] #5290

rafalste opened this issue Nov 12, 2024 · 3 comments

Comments

@rafalste
Copy link

What happened:
Error during compilation:

[root@master juicefs]# make
go version
go version go1.23.2 (Red Hat 1.23.2-1.el9) linux/amd64
go build -ldflags="-s -w -X github.com/juicedata/juicefs/pkg/version.revision=cd871d19 -X github.com/juicedata/juicefs/pkg/version.revisionDate=2024-08-30"  -o juicefs .
# github.com/grafana/pyroscope-go/godeltaprof/internal/pprof
../go/pkg/mod/github.com/grafana/pyroscope-go/[email protected]/internal/pprof/delta_mutex.go:30:20: undefined: runtime_cyclesPerSecond
../go/pkg/mod/github.com/grafana/pyroscope-go/[email protected]/internal/pprof/proto.go:320:8: undefined: runtime_expandFinalInlineFrame
make: *** [Makefile:24: juicefs] Error 1

Solution:
Bump up the version of godeltaprof in go.mod to 0.1.8

Environment:

  • JuiceFS version (use juicefs --version): 1.2.1+2024-08-30.cd871d19
  • OS (e.g cat /etc/os-release): CentOS Stream 9
  • Kernel (e.g. uname -a): 5.14.0-522.el9.x86_64
@rafalste rafalste added the kind/bug Something isn't working label Nov 12, 2024
@jiefenghuang jiefenghuang removed the kind/bug Something isn't working label Nov 13, 2024
@jiefenghuang
Copy link
Contributor

If you need support for Go 1.23, you can switch to the latest main branch.

@rafalste
Copy link
Author

rafalste commented Nov 13, 2024

Hey @jiefenghuang, I used the latest JuiceFS stable release (v1.2.1) and Go version from Centos repo, nothing exotic. In the JuiceFS compilation documentation there is a dependency of Go 1.20+ and no mention that 1.23 is too high.
Nevertheless, I just left the solution here in case anyone else trips on the same issue. Feel free to close it.
Cheers!

@davies
Copy link
Contributor

davies commented Nov 18, 2024

@rafalste We will cherry-pick the patch for 1.2 branch, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants