Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The stageBlockBytes should calculate the checksum length #3450

Closed
zhijian-pro opened this issue Apr 10, 2023 · 1 comment · Fixed by #3459
Closed

The stageBlockBytes should calculate the checksum length #3450

zhijian-pro opened this issue Apr 10, 2023 · 1 comment · Fixed by #3459
Assignees
@zhijian-pro

Comments

@zhijian-pro
Copy link
Contributor

zhijian-pro commented Apr 10, 2023 •
edited
Loading

writeback files may contain checksum values, so the stageBlockBytes deletions should use parseObjOrigSize(key) rather than fi.size
@zhijian-pro zhijian-pro self-assigned this Apr 10, 2023
@zyfjeff
Copy link
Contributor

zyfjeff commented Apr 10, 2023

Indeed, many places in the code has mixed file size and object size.

This was referenced Apr 11, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhijian-pro zhijian-pro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

metric: fix stageBlockBytes calculation method juicedata/juicefs
2 participants
@zyfjeff @zhijian-pro