From 00ca507a5eebbc3d20696c58531163780acc98e2 Mon Sep 17 00:00:00 2001 From: Changxin Miao Date: Thu, 6 Feb 2025 14:47:49 +0800 Subject: [PATCH] Fix type assert to `*os.File` never works for `cacheFile` (#5615) Signed-off-by: Changxin Miao --- pkg/chunk/cached_store.go | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/pkg/chunk/cached_store.go b/pkg/chunk/cached_store.go index 4fc718fdef0a..5fb5c63fed73 100644 --- a/pkg/chunk/cached_store.go +++ b/pkg/chunk/cached_store.go @@ -142,10 +142,8 @@ func (s *rSlice) ReadAt(ctx context.Context, page *Page, off int) (n int, err er s.store.cacheReadHist.Observe(time.Since(start).Seconds()) return n, nil } - if f, ok := r.(*os.File); ok { - logger.Warnf("remove partial cached block %s: %d %s", f.Name(), n, err) - _ = os.Remove(f.Name()) - } + logger.Warnf("remove partial cached block %s: %d %s", key, n, err) + s.store.bcache.remove(key, false) } } @@ -462,7 +460,7 @@ func (s *wSlice) upload(indx int) { stageFailed = true if !errors.Is(err, errStageConcurrency) { s.store.stageBlockErrors.Add(1) - logger.Warnf("write %s to disk: %s, upload it directly", stagingPath, err) + logger.Warnf("write %s to disk: %s, upload it directly", key, err) } } else { s.errors <- nil