-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Populate name field in exported span with http.target attribute #207
Comments
Hi, @FieteO |
Ah, I think I see what you mean. The spec is saying: "HTTP span names SHOULD be While Here, the client case applies and thus a Even though this is against the spec, could we perhaps hide this implementation behind a configuration? |
Yes, that is indeed the problem, and you have forgotten this sentence: The instrumentation MUST NOT use the URI path as the default {target}. |
First of all, thanks for providing this library to support tracing in web apps! I am using it in conjunction with Jaeger for end to end traces.
This works great, but I would have one improvement for the exported spans.
The picture above shows an example trace in the jaeger ui starting from the web app. The ui shows the names of the individual spans
in the Service & Operations pane in the center left of the image.
For the web app, the span name is displayed as
GET
, while for traces from other (spring-boot) apps, the endpoint url (i.ehttp get /customers/{customerId}
) is used.Looking at the json response in jaeger reveals that the field is called
operationName
that determines the name.Now, when looking at the request of the span exporter, the field that would correspond to this is likely the
name
field:Now my question: Is it possible to configure the exporter to use for instance the
tags.http.target
attribute instead of the http method?If not, could it be implemented?
The text was updated successfully, but these errors were encountered: