fix: avoid unnecessary exception on flattenReducer

juanjoDiaz · Nov 7, 2022 · 8b7dd1e · 8b7dd1e
1 parent 04867ae
commit 8b7dd1e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/plainjs/src/utils.js b/packages/plainjs/src/utils.js
@@ -6,7 +6,7 @@ export function getProp(obj, path, defaultValue) {
 export function flattenReducer(acc, arr) {
   try {
     // This is faster but susceptible to `RangeError: Maximum call stack size exceeded`
-    acc.push(...arr);
+    Array.isArray(arr) ? acc.push(...arr) : acc.push(arr);
     return acc;
   } catch (err) {
     // Fallback to a slower but safer option

diff --git a/packages/transforms/src/utils.js b/packages/transforms/src/utils.js
@@ -36,7 +36,7 @@ export function unsetProp(obj, path) {
 export function flattenReducer(acc, arr) {
   try {
     // This is faster but susceptible to `RangeError: Maximum call stack size exceeded`
-    acc.push(...arr);
+    Array.isArray(arr) ? acc.push(...arr) : acc.push(arr);
     return acc;
   } catch (err) {
     // Fallback to a slower but safer option