Create save_dir if it does not exist, and allow configuration of starting painting mode
#123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaoyang Zhang <[email protected]>
Signed-off-by: Gaoyang Zhang <[email protected]>
Signed-off-by: Gaoyang Zhang <[email protected]>
|
Thanks @blurgyy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made 2 changes:
save_dirto exist, when trying to save edited image to a non-existingsave_dir, swappy does not save it at all. In 0b1c6e9, I add code to attempt to createsave_dirif it does not already exists.paint_modein b6c2c60, to allow a user to configure the start up painting mode of swappy.Documentation and readme are updated according to the above 2 modifications in 476ae90.