-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is it possible to move away from V8 in favor of a liter dependency? Say, QuickJSR
#81
Comments
It's an interesting idea, but V8 is very fast and QuickJS seems to be quite a bit slower ... I don't know if that would be a bottleneck or not? Could be an interesting thing to test. |
I cannot vouch personally for speed (since V8 is broken for the platform where I test), but given that
|
@jtextor Maybe you could make a branch with a switch to QuickJSR? That would fix dagitty without compromising it for those preferring V8. |
@jtextor Any update on this? |
I am experiencing an issue due to V8 dependency as well
Apparently the V8 package's shared object file (V8.so) is not linking correctly to the C++ standard library (libc++.1.dylib) on your macOS ARM64 system.
|
@Lulliter While I do endorse moving away from V8 here, you could probably get V8 built from source, and if whatever its default V8 is fails to, then build it against a different version. As I recall, it is supposed to accept a wide range of V8 versions. Does MacPorts |
@barracuda156 I am not familiar with MacPorts, but I tried installing V8 from source, reinstalling command tools, etc. In the end, what solved the incompatibility was updating also my Mac OS. So now I can load
|
Apple messed up Xcode quite badly recently, and several times, so that some versions are incompatible with each other on the same system, could be due to that. Anyway, good that it works now. |
@jtextor
V8
is a very heavy dependency to build and it is broken for some platforms. Could we get rid of it? Possibly, replacing withQuickJSR
, likerstan
did?The text was updated successfully, but these errors were encountered: