Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http hardcoded in generated urls, https option would be nice #24

Open
dgoldenichec opened this issue Aug 18, 2009 · 2 comments
Open

http hardcoded in generated urls, https option would be nice #24

dgoldenichec opened this issue Aug 18, 2009 · 2 comments

Comments

@dgoldenichec
Copy link

There are a few places that assume http:// during url generation. If you want https:// , presently have to locally modify feeds.py and models.py. A global settings.NOTIFICATION_USE_HTTPS might do, people are hardly likely to want a mix of http:// and https://

get_tag_uri in atomformat.py might also need to say '^https?://' when substituting.

@dgoldenichec
Copy link
Author

as per trivial fork just created

@dgoldenichec
Copy link
Author

N.B. This is addressed in pinax django-notification 0.1.5 plus, one can now do DEFAULT_HTTP_PROTOCOL="https" in settings.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant