Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Digest Email Support #23

Open
TristanBrotherton opened this issue May 21, 2009 · 9 comments
Open

Digest Email Support #23

TristanBrotherton opened this issue May 21, 2009 · 9 comments

Comments

@TristanBrotherton
Copy link

Would be a good feature for email notifications, allowing a user to have all notifications added to one email to receive once per day.

@adamn
Copy link

adamn commented Aug 26, 2009

An important part of this would be to first create a batch concept more generally. For instance, if an event is triggered 1,000 times, there should be a method to bundle that into one notice. That notice would then form the basis of your digest email.

@adamn
Copy link

adamn commented Aug 26, 2009

I'm probably going to do a patch on engine.py around line 47 or so to allow for a notice_type/user grouping feature when emit_notices is signaled.

@adamn
Copy link

adamn commented Aug 26, 2009

A comment from a committer would be helpful here.

@TristanBrotherton
Copy link
Author

Any more thoughts on this? I'm consider doing a fork two implement. Our users really want a digest mode.

@adamn
Copy link

adamn commented Nov 30, 2009

A digest mode is critical but after reading alot of this code I realized that django-notification and django-mailer are tightly coupled and they need to be worked on as a unit. In addition, the Pinax team wants to do a pluggable backend for the notification system - but I haven't seen any of that code.

I'm sorry but I don't have any good comments right now - I haven't looked at the code in about 3 months and I remember noting that this would be a serious change.

Cheers,
Adam

@adamn
Copy link

adamn commented Dec 2, 2009

Tristan, have you started the fork. Coincidentally, I now need this functionality.

@TristanBrotherton
Copy link
Author

Hi AdamN - we are trying to work out the best way to implement internally.
Ideally I'd like an option on notification preferences "digest my notifications" which would send one email a day with all notifications in it - probably using a different set of templates.

@adamn
Copy link

adamn commented Dec 2, 2009

This might be best accomplished in jtauber/django-mailer

@adamn
Copy link

adamn commented Dec 2, 2009

Ok, I started this post on pinax-users:

http://groups.google.com/group/pinax-users/browse_thread/thread/a493a88f5e9527c7

I don't think django-mailer ever implemented the digest functionality and it doesn't seem like the right place to have it anyway. I'm going to try to work on this today and tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants