New option: jsx-one-expression-per-line non-jsx

[reediculous456]

Examples of incorrect code for this rule:

<Hello
  foo="bar
>Children
</Hello>

Examples of correct code for this rule:

<Hello
  foo="bar
>
  Children
</Hello>

[ljharb]

See https://github.com/jsx-eslint/eslint-plugin-react/blob/HEAD/docs/rules/jsx-one-expression-per-line.md

[reediculous456]

I don't believe this rule quite accomplishes my use case. For example, I want this to be correct:

<>Some text is: {variable} and goes here.</>

but with that rule it wants to make it:

<>
  Some text is:
  {` `}
  {variable}
  {` `}
  and goes here.
</>

I'm specifically looking to prevent the case of having multiline props but not multiline children

[ljharb]

If you set allow to literal?

[reediculous456]

Ends up with the same result. I think the rule interprets putting in a variable as a non-literal causing it to force it to multiline.

The single-child option seems closest to what I want, but I would want it to consider Some text is: {variable} and goes here. as a single child and allow that to stay on one line

[ljharb]

ah, well sure, a variable isn't a literal.

hmm, that seems like a reasonable option to add - non-jsx, which would allow a single line child for anything that's not a literal jsx element?

[burtek]

@ljharb happy to tackle this in coming days

[ljharb]

That'd be great, thanks!

[burtek]

@ljharb So just to be sure I understand it correctly. The allow: 'non-jsx' would disallow:

<Foo>
    <Bar /><Bar /><Bar />
</Foo>

<Foo>
    aaa<Bar />bbb
</Foo>

but allow:

<Foo>
    aaa {variable} bbb
</Foo>

Right?

[reediculous456]

That’s what I’m looking for

[burtek]

ok, will work on this then. Hopefully will have PR ready this evening (Europe time)

[reediculous456]

@ljharb whats the release timeline for this project? I see there haven’t been any releases since August and there are a couple of merged things I’m waiting on

[ljharb]

@reediculous456 there's no strict timeline, but i'll likely cut a release sooner than later.

[burtek]

I hope to get #3678 in as well :)