-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] jsx-curly-brace-presence
: handle single and only expression template literals
#3538
Conversation
…emplate literals
Codecov Report
@@ Coverage Diff @@
## master #3538 +/- ##
=======================================
Coverage 97.60% 97.60%
=======================================
Files 132 132
Lines 9275 9282 +7
Branches 3389 3392 +3
=======================================
+ Hits 9053 9060 +7
Misses 222 222
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jsx-curly-brace-presence
: handle single and only expression template literals
Hi @ljharb, I believe this change is wrong. This is a valid use case for stringifying a primitive (e.g., from number to string). Although you could do it via If you insist on keeping it as it is, I suggest putting it behind a flag 🙏. |
let me revert this now |
@Newbie012 yes, you're right, it should be reverted. |
…ession template literals" This reverts commit 099b14c / jsx-eslint#3538. Fixes jsx-eslint#3607.
…ession template literals" This reverts commit 099b14c / jsx-eslint#3538. Fixes jsx-eslint#3607.
…ession template literals" This reverts commit 099b14c / jsx-eslint#3538. Fixes jsx-eslint#3607.
…ession template literals" This reverts commit 099b14c / jsx-eslint#3538. Fixes jsx-eslint#3607.
fix #3537