Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown Property Issue with 7.31.6 #3396

Closed
djaffer opened this issue Sep 5, 2022 · 10 comments
Closed

Unknown Property Issue with 7.31.6 #3396

djaffer opened this issue Sep 5, 2022 · 10 comments

Comments

@djaffer
Copy link

djaffer commented Sep 5, 2022

Getting the following errors with the recent upgrade.
image

@ljharb
Copy link
Member

ljharb commented Sep 5, 2022

download was fixed in #3394.

@ljharb
Copy link
Member

ljharb commented Sep 5, 2022

Can you elaborate on which element has underline?

@ljharb ljharb closed this as completed in 7ba7ec4 Sep 5, 2022
@djaffer
Copy link
Author

djaffer commented Sep 5, 2022

Material ui https://v4.mui.com/api/link/, probably it uses for a tag. Why is this bug closed? @ljharb

@ljharb
Copy link
Member

ljharb commented Sep 5, 2022

On what element? You didn’t provide any code. Can you file a new issue for that?

@djaffer
Copy link
Author

djaffer commented Sep 5, 2022

It is a link what source you need that for

import { Link } from '@material-ui/core';
<Link href="https://github.com" underline="none">test</Link>

The build is failing now too.

@ljharb
Copy link
Member

ljharb commented Sep 5, 2022

Have your settings configured Link to act as an a tag?

If so, since underline isn’t a standard link property, you’ll have to add “underline” to your ignore config for this rule.

@djaffer
Copy link
Author

djaffer commented Sep 5, 2022

yes if you don't provide anything it works as a tag.

https://codesandbox.io/s/material-demo-forked-hxk871?file=/demo.js

image

@djaffer
Copy link
Author

djaffer commented Sep 5, 2022

Will it be like this in eslintrc.json?

"react/no-unknown-property":[1, { ignore: ['underline']}]

Also, how do you turn this rule off. I tried below. It did not work.

 "react/no-unknown-property":[0]

@ljharb
Copy link
Member

ljharb commented Sep 5, 2022

Yes to both. No idea why it doesn’t work.

@djaffer
Copy link
Author

djaffer commented Sep 5, 2022

only worked in eslintrc.js not in eslintrc.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants