Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-unknown-property: breaking change between versions 7.31.1 and 7.31.5 #3391

Closed
mrtnzlml opened this issue Sep 4, 2022 · 1 comment
Closed

Comments

@mrtnzlml
Copy link
Contributor

mrtnzlml commented Sep 4, 2022

Hello! 👋 I received a PR with a patch upgrade (see: adeira/universe#4976), containing 571 new errors. It turns out there was some breaking change in the react/no-unknown-property rule, and it currently fails on FBT nodes, for example:

<fbt desc="test tooltip content title" doNotExtract={true}>
  This is a test tooltip content.
</fbt>

Resulting in:

22:14  error  Unknown property 'desc' found          react/no-unknown-property
22:48  error  Unknown property 'doNotExtract' found  react/no-unknown-property

Recently, I reported several issues related to FBT, and they were all fixed, and some rules support it (https://github.com/jsx-eslint/eslint-plugin-react/search?q=fbt&type=code). But I agree that FBT is a bit awkward React citizen, so not sure if this is going to be taken very seriously. 😅

Thanks for having a look! 😎

@ljharb
Copy link
Member

ljharb commented Sep 4, 2022

It’s a bug, not a breaking change. Thanks for the report, we’ll get it fixed!

@ljharb ljharb closed this as completed in d2c9bef Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants