Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[react/no-unknown-property] does not recognize <td valign={...} #3389

Closed
simPod opened this issue Sep 4, 2022 · 2 comments
Closed

[react/no-unknown-property] does not recognize <td valign={...} #3389

simPod opened this issue Sep 4, 2022 · 2 comments
Assignees
@ljharb

Comments

@simPod
Copy link

simPod commented Sep 4, 2022

Unknown property 'valign' found react/no-unknown-property

<td colSpan={colSpan} valign="middle">
  foo
</td>

valign is valid property on td
@sjarva
Copy link
Contributor

sjarva commented Sep 4, 2022 •
edited
Loading

MDN has marked valign as deprecated and recommends using vertical-align instead.

But, I think that it is a good question should the rule accept deprecated properties or not.

@ljharb
Copy link
Member

ljharb commented Sep 4, 2022

I think it should; deprecated is known.

@ljharb ljharb self-assigned this Sep 5, 2022
@ljharb ljharb closed this as completed in 64ad602 Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ljharb ljharb

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ljharb @simPod @sjarva