Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Replacing legacy ref string with ref variable #3375

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

Luccasoli
Copy link
Contributor

Just rewriting ref props using ref variables.

@Luccasoli Luccasoli changed the title [Docs] Replacing ref string with ref variable [Docs] Replacing legacy ref string with ref variable Aug 30, 2022
@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #3375 (3d58253) into master (9055439) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3375   +/-   ##
=======================================
  Coverage   97.56%   97.56%           
=======================================
  Files         123      123           
  Lines        8929     8929           
  Branches     3257     3257           
=======================================
  Hits         8712     8712           
  Misses        217      217           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ljharb
Copy link
Member

ljharb commented Aug 30, 2022

I think it’d be better to add these examples instead of changing them, since both patterns are checked.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this is fine as-is

@Luccasoli
Copy link
Contributor Author

Luccasoli commented Aug 30, 2022

Thanks, it's just that I was doing some reading and noticed this detail 😅

@ljharb ljharb merged commit 3d58253 into jsx-eslint:master Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants