Results of weekly scheduled smoke test

[github-actions]

Something went wrong.

Click to expand

HttpError: Validation Failed: {"resource":"Issue","code":"custom","field":"body","message":"body is too long (maximum is 65536 characters)"}
    at /index.js:2869:26
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at async GithubClient.requestAndRetry (/index.js:5786:12)
    at async GithubClient.createIssue (/index.js:5819:5)
    at async /index.js:5977:7

[ljharb]

cc @AriPerkkio seems unrelated to the linter?

[ljharb]

ah, looking at the actual output, it’s just that there were so many failures :-) on it.

[AriPerkkio]

Yes, looks like the react/jsx-key crashed over 1000 times.

The custom Github Action eslint-remote-tester-run-action already limits the result count into 50 results when posting a comment. I guess one of the error messages just had extremely long stack traces or something, which caused +65k characters in bot's comment. I think I'll need to add some extra handling here to prevent these crashes. Thanks for ping. 👍

[ljharb]

Hmm, unfortunately it seems the actions output isn't actually helpful - there's no stack trace or anything. Any idea how i can get to repro code?

[AriPerkkio]

The action does output the results as "raw output" in CI logs - exactly for cases like this. It's meant to be a backup. By looking at the CI's logs in text-only mode these are easily visible.

CTRL + F > search for Results:

Here are the first three results:

Repository: iam4x/bobarr
Rule: react/jsx-key
Message: Cannot read property 'forEach' of undefined Occurred while linting /github/workspace/node_modules/eslint-remote-tester/.cache-eslint-remote-tester/iam4x/bobarr/packages/web/components/movie-details/rating-details.component.tsx:28
Rule: "react/jsx-key"
Path: iam4x/bobarr/packages/web/components/movie-details/rating-details.component.tsx
Link: https://github.com/iam4x/bobarr/blob/HEAD/packages/web/components/movie-details/rating-details.component.tsx#L28

  26 |   return (
  27 |     <RatingDetailsStyles>
> 28 |       {Object.entries(allRatings)?.map(([key, value], index) => {
  29 |         const rate = value?.split(/(?=[%, /])/);
  30 |
  31 |         if (!rate) return null;

Error: TypeError: Cannot read property 'forEach' of undefined
Occurred while linting /github/workspace/node_modules/eslint-remote-tester/.cache-eslint-remote-tester/iam4x/bobarr/packages/web/components/movie-details/rating-details.component.tsx:28
Rule: "react/jsx-key"
    at getReturnStatements (/github/workspace/lib/rules/jsx-key.js:99:19)
    at getReturnStatements (/github/workspace/lib/rules/jsx-key.js:93:11)
    at /github/workspace/lib/rules/jsx-key.js:101:13
    at Array.forEach (<anonymous>)
    at getReturnStatements (/github/workspace/lib/rules/jsx-key.js:99:19)
    at CallExpression[callee.type="MemberExpression"][callee.property.name="map"],       CallExpression[callee.type="OptionalMemberExpression"][callee.property.name="map"],       OptionalCallExpression[callee.type="MemberExpression"][callee.property.name="map"],       OptionalCallExpression[callee.type="OptionalMemberExpression"][callee.property.name="map"] (/github/workspace/lib/rules/jsx-key.js:212:13)
    at ruleErrorHandler (/github/workspace/node_modules/eslint/lib/linter/linter.js:1114:28)
    at /github/workspace/node_modules/eslint/lib/linter/safe-emitter.js:45:58
    at Array.forEach (<anonymous>)
    at Object.emit (/github/workspace/node_modules/eslint/lib/linter/safe-emitter.js:45:38)

Repository: yanqirenshi/D3.Deployment
Rule: react/jsx-key
Message: Cannot read property 'forEach' of undefined
Occurred while linting /github/workspace/node_modules/eslint-remote-tester/.cache-eslint-remote-tester/yanqirenshi/D3.Deployment/docs/libs/d3.js:751
Rule: "react/jsx-key"
Path: yanqirenshi/D3.Deployment/docs/libs/d3.js
Link: https://github.com/yanqirenshi/D3.Deployment/blob/HEAD/docs/libs/d3.js#L751

  749 |
  750 | function parseTypenames(typenames, types) {
> 751 |   return typenames.trim().split(/^|\s+/).map(function(t) {
  752 |     var name = "", i = t.indexOf(".");
  753 |     if (i >= 0) name = t.slice(i + 1), t = t.slice(0, i);
  754 |     if (t && !types.hasOwnProperty(t)) throw new Error("unknown type: " + t);

Error:
TypeError: Cannot read property 'forEach' of undefined
Occurred while linting /github/workspace/node_modules/eslint-remote-tester/.cache-eslint-remote-tester/yanqirenshi/D3.Deployment/docs/libs/d3.js:751
Rule: "react/jsx-key"
    at getReturnStatements (/github/workspace/lib/rules/jsx-key.js:99:19)
    at getReturnStatements (/github/workspace/lib/rules/jsx-key.js:93:11)
    at /github/workspace/lib/rules/jsx-key.js:101:13
    at Array.forEach (<anonymous>)
    at getReturnStatements (/github/workspace/lib/rules/jsx-key.js:99:19)
    at CallExpression[callee.type="MemberExpression"][callee.property.name="map"],       CallExpression[callee.type="OptionalMemberExpression"][callee.property.name="map"],       OptionalCallExpression[callee.type="MemberExpression"][callee.property.name="map"],       OptionalCallExpression[callee.type="OptionalMemberExpression"][callee.property.name="map"] (/github/workspace/lib/rules/jsx-key.js:212:13)
    at ruleErrorHandler (/github/workspace/node_modules/eslint/lib/linter/linter.js:1114:28)
    at /github/workspace/node_modules/eslint/lib/linter/safe-emitter.js:45:58
    at Array.forEach (<anonymous>)
    at Object.emit (/github/workspace/node_modules/eslint/lib/linter/safe-emitter.js:45:38)

Repository: yanqirenshi/D3.Deployment
Rule: react/jsx-key
Message: Cannot read property 'forEach' of undefined
Occurred while linting /github/workspace/node_modules/eslint-remote-tester/.cache-eslint-remote-tester/yanqirenshi/D3.Deployment/riot/d3.js:751
Rule: "react/jsx-key"
Path: yanqirenshi/D3.Deployment/riot/d3.js
Link: https://github.com/yanqirenshi/D3.Deployment/blob/HEAD/riot/d3.js#L751

  749 |
  750 | function parseTypenames(typenames, types) {
> 751 |   return typenames.trim().split(/^|\s+/).map(function(t) {
  752 |     var name = "", i = t.indexOf(".");
  753 |     if (i >= 0) name = t.slice(i + 1), t = t.slice(0, i);
  754 |     if (t && !types.hasOwnProperty(t)) throw new Error("unknown type: " + t);

Error:
TypeError: Cannot read property 'forEach' of undefined
Occurred while linting /github/workspace/node_modules/eslint-remote-tester/.cache-eslint-remote-tester/yanqirenshi/D3.Deployment/riot/d3.js:751
Rule: "react/jsx-key"
    at getReturnStatements (/github/workspace/lib/rules/jsx-key.js:99:19)
    at getReturnStatements (/github/workspace/lib/rules/jsx-key.js:93:11)
    at /github/workspace/lib/rules/jsx-key.js:101:13
    at Array.forEach (<anonymous>)
    at getReturnStatements (/github/workspace/lib/rules/jsx-key.js:99:19)
    at CallExpression[callee.type="MemberExpression"][callee.property.name="map"],       CallExpression[callee.type="OptionalMemberExpression"][callee.property.name="map"],       OptionalCallExpression[callee.type="MemberExpression"][callee.property.name="map"],       OptionalCallExpression[callee.type="OptionalMemberExpression"][callee.property.name="map"] (/github/workspace/lib/rules/jsx-key.js:212:13)
    at ruleErrorHandler (/github/workspace/node_modules/eslint/lib/linter/linter.js:1114:28)
    at /github/workspace/node_modules/eslint/lib/linter/safe-emitter.js:45:58
    at Array.forEach (<anonymous>)
    at Object.emit (/github/workspace/node_modules/eslint/lib/linter/safe-emitter.js:45:38)