Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make jsx-no-script-url use shared settings to specify link components #2865

Closed
burtek opened this issue Dec 1, 2020 · 3 comments · Fixed by #3673
Closed

Make jsx-no-script-url use shared settings to specify link components #2865

burtek opened this issue Dec 1, 2020 · 3 comments · Fixed by #3673
Labels
help wanted

Comments

@burtek
Copy link
Contributor

burtek commented Dec 1, 2020

Why do we have to specify Link components in react/jsx-no-script-url settings when we already have that in shared config? Can't shared config be used here, as it is in react/jsx-no-target-blank?
@ljharb
Copy link
Member

ljharb commented Dec 3, 2020

That's a very good point. This could possibly be a non-breaking change - to make the rule, in the absence of specific inline config, defer to the shared config. It'd be worth a PR.

@burtek
Copy link
Contributor Author

burtek commented Dec 16, 2020

I can try it this weekend if I find time

@burtek burtek mentioned this issue Jan 8, 2024
Merged
@burtek
Copy link
Contributor Author

burtek commented Jan 8, 2024 •
edited
Loading

Started working on this after 3 years :D

@ljharb question EDIT: moved question to the PR (#3673 (comment))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[jsx-no-script-url]: use shared settings to specify link components burtek/eslint-plugin-react
2 participants
@ljharb @burtek