From 77048c8fe609f11ad3ee865d0cb7d0f372c0271b Mon Sep 17 00:00:00 2001 From: Yannick Croissant Date: Mon, 24 Apr 2017 00:00:51 +0200 Subject: [PATCH] Remove deprecated wrap-multilines rule --- index.js | 1 - lib/rules/wrap-multilines.js | 58 ----------- tests/lib/rules/wrap-multilines.js | 161 ----------------------------- 3 files changed, 220 deletions(-) delete mode 100644 lib/rules/wrap-multilines.js delete mode 100644 tests/lib/rules/wrap-multilines.js diff --git a/index.js b/index.js index 5bb28e49db..3226b9bc46 100644 --- a/index.js +++ b/index.js @@ -61,7 +61,6 @@ var allRules = { 'no-unused-prop-types': require('./lib/rules/no-unused-prop-types'), 'no-children-prop': require('./lib/rules/no-children-prop'), 'void-dom-elements-no-children': require('./lib/rules/void-dom-elements-no-children'), - 'wrap-multilines': require('./lib/rules/wrap-multilines'), 'jsx-tag-spacing': require('./lib/rules/jsx-tag-spacing') }; diff --git a/lib/rules/wrap-multilines.js b/lib/rules/wrap-multilines.js deleted file mode 100644 index 439acbbe82..0000000000 --- a/lib/rules/wrap-multilines.js +++ /dev/null @@ -1,58 +0,0 @@ -/** - * @fileoverview Prevent missing parentheses around multilines JSX - * @author Yannick Croissant - * @deprecated - */ -'use strict'; - -// ------------------------------------------------------------------------------ -// Rule Definition -// ------------------------------------------------------------------------------ - -var util = require('util'); -var jsxWrapMultilines = require('./jsx-wrap-multilines'); -var isWarnedForDeprecation = false; - -module.exports = { - meta: { - deprecated: true, - docs: { - description: 'Prevent missing parentheses around multilines JSX', - category: 'Stylistic Issues', - recommended: false - }, - fixable: 'code', - - schema: [{ - type: 'object', - properties: { - declaration: { - type: 'boolean' - }, - assignment: { - type: 'boolean' - }, - return: { - type: 'boolean' - } - }, - additionalProperties: false - }] - }, - - create: function(context) { - return util._extend(jsxWrapMultilines.create(context), { - Program: function() { - if (isWarnedForDeprecation || /\=-(f|-format)=/.test(process.argv.join('='))) { - return; - } - - /* eslint-disable no-console */ - console.log('The react/wrap-multilines rule is deprecated. Please ' + - 'use the react/jsx-wrap-multilines rule instead.'); - /* eslint-enable no-console */ - isWarnedForDeprecation = true; - } - }); - } -}; diff --git a/tests/lib/rules/wrap-multilines.js b/tests/lib/rules/wrap-multilines.js deleted file mode 100644 index 11fb78b474..0000000000 --- a/tests/lib/rules/wrap-multilines.js +++ /dev/null @@ -1,161 +0,0 @@ -/** - * @fileoverview Prevent missing parentheses around multilines JSX - * @author Yannick Croissant - */ -'use strict'; - -// ------------------------------------------------------------------------------ -// Requirements -// ------------------------------------------------------------------------------ - -var rule = require('../../../lib/rules/wrap-multilines'); -var RuleTester = require('eslint').RuleTester; - -var parserOptions = { - ecmaVersion: 6, - ecmaFeatures: { - jsx: true - } -}; - -// ------------------------------------------------------------------------------ -// Code Snippets -// ------------------------------------------------------------------------------ - -var RETURN_SINGLE_LINE = ` - var Hello = createReactClass({ - render: function() { - return

Hello {this.props.name}

; - } - }); -`; - -var RETURN_PAREN = ` - var Hello = createReactClass({ - render: function() { - return (
-

Hello {this.props.name}

-
); - } - }); -`; - -var RETURN_NO_PAREN = ` - var Hello = createReactClass({ - render: function() { - return
-

Hello {this.props.name}

-
; - } - }); -`; - -var DECLARATION_SINGLE_LINE = 'var hello =

Hello

;'; - -var DECLARATION_PAREN = ` - var hello = (
-

Hello

-
); -`; - -var DECLARATION_NO_PAREN = ` - var hello =
-

Hello

-
; -`; - -var ASSIGNMENT_SINGLE_LINE = 'var hello; hello =

Hello

;'; - -var ASSIGNMENT_PAREN = ` - var hello; - hello = (
-

Hello

-
); -`; - -var ASSIGNMENT_NO_PAREN = ` - var hello; - hello =
-

Hello

-
; -`; - -// ------------------------------------------------------------------------------ -// Tests -// ------------------------------------------------------------------------------ - -var ruleTester = new RuleTester(); -ruleTester.run('wrap-multilines', rule, { - - valid: [ - { - code: RETURN_SINGLE_LINE, - parserOptions: parserOptions - }, { - code: RETURN_PAREN, - parserOptions: parserOptions - }, { - code: RETURN_NO_PAREN, - options: [{return: false}], - parserOptions: parserOptions - }, { - code: DECLARATION_SINGLE_LINE, - parserOptions: parserOptions - }, { - code: DECLARATION_PAREN, - parserOptions: parserOptions - }, { - code: DECLARATION_NO_PAREN, - options: [{declaration: false}], - parserOptions: parserOptions - }, { - code: ASSIGNMENT_SINGLE_LINE, - options: [{declaration: false}], - parserOptions: parserOptions - }, { - code: ASSIGNMENT_PAREN, - parserOptions: parserOptions - }, { - code: ASSIGNMENT_NO_PAREN, - options: [{assignment: false}], - parserOptions: parserOptions - } - ], - - invalid: [ - { - code: RETURN_NO_PAREN, - output: RETURN_PAREN, - parserOptions: parserOptions, - errors: [{message: 'Missing parentheses around multilines JSX'}] - }, { - code: RETURN_NO_PAREN, - output: RETURN_PAREN, - parserOptions: parserOptions, - options: [{return: true}], - errors: [{message: 'Missing parentheses around multilines JSX'}] - }, { - code: DECLARATION_NO_PAREN, - output: DECLARATION_PAREN, - parserOptions: parserOptions, - errors: [{message: 'Missing parentheses around multilines JSX'}] - }, { - code: DECLARATION_NO_PAREN, - output: DECLARATION_PAREN, - parserOptions: parserOptions, - options: [{declaration: true}], - errors: [{message: 'Missing parentheses around multilines JSX'}] - }, { - code: ASSIGNMENT_NO_PAREN, - output: ASSIGNMENT_PAREN, - parserOptions: parserOptions, - errors: [{message: 'Missing parentheses around multilines JSX'}] - }, { - code: ASSIGNMENT_NO_PAREN, - output: ASSIGNMENT_PAREN, - parserOptions: parserOptions, - options: [{assignment: true}], - errors: [{message: 'Missing parentheses around multilines JSX'}] - } - ] -});