From c0733f94031fe3eec6b4d54176afe47929bb0a84 Mon Sep 17 00:00:00 2001 From: Kate Higa <16447748+khiga8@users.noreply.github.com> Date: Mon, 28 Aug 2023 11:57:15 -0400 Subject: [PATCH 1/2] [New] `no-noninteractive-element-to-interactive-role`: allow `menuitemradio` and `menuitemcheckbox` on
  • --- .../rules/no-noninteractive-element-to-interactive-role-test.js | 2 ++ src/index.js | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/__tests__/src/rules/no-noninteractive-element-to-interactive-role-test.js b/__tests__/src/rules/no-noninteractive-element-to-interactive-role-test.js index da1f4f802..ec14adb23 100644 --- a/__tests__/src/rules/no-noninteractive-element-to-interactive-role-test.js +++ b/__tests__/src/rules/no-noninteractive-element-to-interactive-role-test.js @@ -457,6 +457,8 @@ ruleTester.run(`${ruleName}:recommended`, rule, { { code: '
      ;' }, { code: '
    1. ;' }, { code: '
    2. ;' }, + { code: '
    3. ;' }, + { code: '
    4. ;' }, { code: '
    5. ;' }, { code: '
    6. ;' }, { code: ';' }, diff --git a/src/index.js b/src/index.js index 7b931fe34..752ff6121 100644 --- a/src/index.js +++ b/src/index.js @@ -164,7 +164,7 @@ module.exports = { 'tree', 'treegrid', ], - li: ['menuitem', 'option', 'row', 'tab', 'treeitem'], + li: ['menuitem', 'menuitemradio', 'menuitemcheckbox', 'option', 'row', 'tab', 'treeitem'], table: ['grid'], td: ['gridcell'], fieldset: ['radiogroup', 'presentation'], From 1be7b709eececd83f1d5f67a60b2c97cfe9a561d Mon Sep 17 00:00:00 2001 From: Jordan Harband Date: Tue, 30 Jan 2024 12:11:53 -0800 Subject: [PATCH 2/2] [Deps] move `object.entries` to dev deps --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index eeed1e6fc..03be59c68 100644 --- a/package.json +++ b/package.json @@ -63,6 +63,7 @@ "minimist": "^1.2.8", "npmignore": "^0.3.1", "object.assign": "^4.1.5", + "object.entries": "^1.1.7", "rimraf": "^3.0.2", "safe-publish-latest": "^2.0.0", "semver": "^6.3.1", @@ -87,7 +88,6 @@ "jsx-ast-utils": "^3.3.5", "language-tags": "^1.0.9", "minimatch": "^3.1.2", - "object.entries": "^1.1.7", "object.fromentries": "^2.0.7", "safe-regex-test": "^1.0.2", "string.prototype.includes": "^2.0.0"