address feedback

.github/workflows/ci-workflow.yml

@@ -121,6 +121,11 @@ jobs:
       with:
         name: integration-tests-${{ matrix.node-version }}
         path: ./coverage/integration/lcov.info
+    - name: Archive Integration (ESM) Test Coverage
+      uses: actions/upload-artifact@v3
+      with:
+        name: integration-tests-${{ matrix.node-version }}
+        path: ./coverage/integration-esm/lcov.info
 
   versioned-internal:
     needs: skip_if_release

lib/shimmer.js

@@ -14,7 +14,7 @@ const shims = require('./shim')
 const { Hook } = require('@newrelic/ritm')
 const IitmHook = require('import-in-the-middle')
 const { nrEsmProxy } = require('./symbols')
-const isAbsolutePath = require('./is-absolute-path')
+const isAbsolutePath = require('./util/is-absolute-path')
 const InstrumentationDescriptor = require('./instrumentation-descriptor')
 const InstrumentationTracker = require('./instrumentation-tracker')
 let pkgsToHook = []

package.json

@@ -157,7 +157,7 @@
     "docker-env": "./bin/docker-env-vars.sh",
     "docs": "npm ci && jsdoc -c ./jsdoc-conf.json --private -r .",
     "integration": "npm run prepare-test && npm run sub-install && time c8 -o ./coverage/integration tap --test-regex='(\\/|^test\\/integration\\/.*\\.tap\\.js)$' --timeout=600 --no-coverage --reporter classic",
-    "integration:esm": "time c8 -o ./coverage/integration tap --node-arg='--loader=./esm-loader.mjs' --test-regex='(test\\/integration\\/.*\\.tap\\.mjs)$' --timeout=600 --no-coverage --reporter classic",
+    "integration:esm": "time c8 -o ./coverage/integration-esm tap --node-arg='--loader=./esm-loader.mjs' --test-regex='(test\\/integration\\/.*\\.tap\\.mjs)$' --timeout=600 --no-coverage --reporter classic",
     "prepare-test": "npm run ssl && npm run docker-env",
     "lint": "eslint ./*.{js,mjs} lib test bin examples",
     "lint:fix": "eslint --fix, ./*.{js,mjs} lib test bin examples",

test/unit/is-absolute-path.test.js

@@ -6,13 +6,14 @@
 'use strict'
 
 const tap = require('tap')
-const isAbsolutePath = require('../../lib/is-absolute-path')
+const isAbsolutePath = require('../../lib/util/is-absolute-path')
 
 tap.test('verifies paths correctly', async (t) => {
   const tests = [
     ['./foo/bar.js', true],
     ['/foo/bar.cjs', true],
     ['/foo.mjs', true],
+    ['/foo.smj', false],
     ['foo', false],
     ['foo.js', false]
   ]

third_party_manifest.json

@@ -1,5 +1,5 @@
 {
-  "lastUpdated": "Thu Apr 25 2024 13:16:20 GMT-0400 (Eastern Daylight Time)",
+  "lastUpdated": "Fri Apr 26 2024 14:57:01 GMT-0400 (Eastern Daylight Time)",
   "projectName": "New Relic Node Agent",
   "projectUrl": "https://github.com/newrelic/node-newrelic",
   "includeOptDeps": true,