Merge pull request newrelic#65 from bizob2828/remove-methods-pkg

removed methods lib and use our own implementation
jsumners-nr · Jul 19, 2021 · ac212a4 · ac212a4
2 parents fde10a2 + fbc9cbc
commit ac212a4
Show file tree

Hide file tree

Showing 6 changed files with 4,897 additions and 8 deletions.
diff --git a/lib/instrumentation/superagent/.gitignore b/lib/instrumentation/superagent/.gitignore
@@ -33,7 +33,6 @@ bower_components
 build/Release
 
 # Dependency directories
-package-lock.json
 node_modules/
 jspm_packages/
 

diff --git a/lib/instrumentation/superagent/lib/http-methods.js b/lib/instrumentation/superagent/lib/http-methods.js
@@ -0,0 +1,4 @@
+'use strict'
+const http = require('http')
+const methodsLower = http.METHODS.map((method) => method.toLowerCase())
+module.exports.METHODS = methodsLower
diff --git a/lib/instrumentation/superagent/lib/instrumentation.js b/lib/instrumentation/superagent/lib/instrumentation.js
@@ -5,7 +5,7 @@
 
 'use strict'
 
-const methods = require('methods')
+const { METHODS } = require('./http-methods')
 
 module.exports = function instrument(shim, superagent) {
   shim.wrapExport(superagent, function wrapRequest(shim, request) {
@@ -16,7 +16,7 @@ module.exports = function instrument(shim, superagent) {
 
     const wrapped = shim.wrapReturn(request, wrapSuperAgentReq)
     Object.assign(wrapped, request)
-    shim.wrapReturn(wrapped, methods, wrapSuperAgentReq)
+    shim.wrapReturn(wrapped, METHODS, wrapSuperAgentReq)
 
     return wrapped
   })