Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodelibs/browser/http.js doesn't emit socket event #79

Closed
garrett-hopper opened this issue May 3, 2022 · 2 comments
Closed

nodelibs/browser/http.js doesn't emit socket event #79

garrett-hopper opened this issue May 3, 2022 · 2 comments

Comments

@garrett-hopper
Copy link

stripe-node's nodeHttpClient depends on a socket event being emitted by the HTTP request before it ends the request.

See: NodeHttpClient.js#L66

Though I'm not sure how Node's http module emits this socket event normally, it seems to be missing in this shim and could potentially cause other packages to break as well.
@garrett-hopper
Copy link
Author

My bad; this appears to be a stream-http issue. It's just being bundled here.

@garrett-hopper
Copy link
Author

Created jhiesey/stream-http#125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@garrett-hopper