Skip to content
This repository has been archived by the owner on Feb 11, 2024. It is now read-only.

Feature Requests #8

Open
AvocadoVR opened this issue Aug 20, 2023 · 6 comments
Open

Feature Requests #8

AvocadoVR opened this issue Aug 20, 2023 · 6 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@AvocadoVR
Copy link

  1. Implement a way to import lyrics for spotify songs. Like LRC files so people can display lyrics for the songs that dont.
  2. Allow an option to disable the timestamp instead have it display the song name and dont update with timestamp.
@jsopn jsopn added enhancement New feature or request good first issue Good for newcomers labels Aug 20, 2023
@jsopn jsopn self-assigned this Aug 20, 2023
@jsopn
Copy link
Owner

jsopn commented Aug 20, 2023

Hi! Thanks for the suggestion, i will try to add support for LRC files, but only after i finish working on issue #5, as it adds the possibility to get current music on pc without depending on Spotify. then support for LRC files will be perfect :)

about the 2nd thing - it is already possible to remove timestamp using config.toml file, you just need to remove these keys {{.currentPos}} / {{.duration}} from NoLyricsFormat and PausedFormat.

End of your config should look like this:

NoLyricsFormat = "▶️ {{.artist}} - {{.name}}"
PausedFormat = "⏸️ {{.artist}} - {{.name}}"

@AvocadoVR
Copy link
Author

What doesn't it keep spamming osc with update messages for the song name and artist

@AvocadoVR
Copy link
Author

https://lrc-maker.github.io/#/editor/
https://github.com/magic-akari/lrc-maker

This is an easy to use lrc maker. An easy way to support lrc. is create a data or local lyrics folder. That checks for the file name of the trackID it currently is. If its not found try to download spotify lyrics. If there is non or unsynced then just display song name.

@jsopn
Copy link
Owner

jsopn commented Aug 21, 2023

What doesn't it keep spamming osc with update messages for the song name and artist

It could be a bug, I'll check it out

This is an easy to use lrc maker. An easy way to support lrc. is create a data or local lyrics folder. That checks for the file name of the trackID it currently is. If its not found try to download spotify lyrics. If there is non or unsynced then just display song name.

Yeah, I know. But as I said, I will only do this functionality after I finish issue #5

@jsopn
Copy link
Owner

jsopn commented Aug 21, 2023

What doesn't it keep spamming osc with update messages for the song name and artist

Fixed in v1.0.3, thank you!

@AvocadoVR

This comment was marked as off-topic.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants