-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change font in 0.5.0? #65
Comments
Unfortunately (or fortunately, depending on how you look at it), Xterm 3 renders the terminal as a I'm trying to avoid adding too many options to this package, especially before we reach a solid base 1.0 release, but let me think on this a little bit. We already use a stylesheet to read in theme colors (a bit of a hack) to pass into the Xterm instance. It's possible we could do the same for fonts. Not going to make any promises as I'm trying to keep things as lean as possible and work "most of the time for most of the users" out of the box. One of the longer term goals is for this library to be able to be extended by other packages to add features and options to do more advanced things (i.e. a |
Those interested in contributing, please see xtermjs/xterm.js#1237 and xtermjs/xterm.js#958 |
If you run some make command inside a terminal it throws a lot of stuff into it. Rendering of such output was adding noticeable overhead to the compilation time for my project. With canvas it is way faster, comparable to native terminal. I wouldn't complain about the decision of upstream. |
Unfortunately that doesn't work for me. I'm on Mac While I see the same propagation in Developer Tools, it's not reflect on the canvas |
I don't believe the style rule would be having any effect. Are you using that font as your editor font, as well? If so, that's probably what is setting it. I should have a release out today or tomorrow that contains the custom font setting, which would allow you to specify this in the settings for the package. |
Yes, I am also using it as my editor font. |
@calebmeyer how do you set your editor font? I have a font set it ITerm2, but that doesn't flow through to xterm |
As mentioned, I'm on windows (iTerm2 is one of the things I miss most from my mac days). All my settings are located here: https://gist.github.com/calebmeyer/57593e1d220fef2910e3d881852a04b3 The one you're probably looking for is this one though. |
Ah sorry, I mistook editor for terminal (?!). I have Editor font set too, but it's not cascading down into xterm But sounds like help is coming in the form of @jsmecham |
I installed from master and it's working beautifully! |
Closed by 656fd18 and released in 0.5.4. |
Well done @jsmecham - pace on this project is awesome. I hope this becomes the standard Terminal in Atom |
I previously had this in my stylesheet:
...with the newer canvas in 0.5.0, this doesn't seem to work.
Is there a way of setting the font?
The text was updated successfully, but these errors were encountered: