Remove IP Match module

Cool concept, but didn't actually work in practice beyond being able
to filter IPs on a local network. The problem is that ztcp doesn't
necessarily record the IP address of the client in the session
table. Instead, it saves the "fully qualified domain name of the peer,
if available, else an IP address." It helps to properly read the
documentation, kids.

Plus, there was a horrible bug in parse_ztcp that was hidden by virtue
of our unit tests running on localhost. In a nutshell, client_ip was
being set to the local host name, usually "0.0.0.0", due to a wrong
index position --- fix coming later since it still affects logging.

Author: jsks

README.md

@@ -32,7 +32,6 @@ Additionally, to run the full test suite the following external commands are req
     - Gzip compression
     - Basic CGI/1.1 support
         - phpMyAdmin appears fully functional, and partially Wordpress (requires configuring for an alternative port)
-    - IP filtering
     - Basic url rewrite
 
 ### Configuration

conf/ip_match.conf

@@ -10,14 +10,12 @@
 # source ~/.config/czhttpd/conf/mime_types.conf
 # source ~/.config/czhttpd/conf/cgi.conf
 # source ~/.config/czhttpd/conf/compress.conf
-# source ~/.config/czhttpd/conf/ip_match.conf
 # source ~/.config/czhttpd/conf/url_rewrite.conf
 # source ~/.config/czhttpd/conf/debug.conf
 
 # Modules
 # source ~/.config/czhttpd/modules/cgi.sh
 # source ~/.config/czhttpd/modules/compress.sh
-# source ~/.config/czhttpd/modules/ip_match.sh
 # source ~/.config/czhttpd/modules/url_rewrite.sh
 # source ~/.config/czhttpd/modules/debug.sh
 

conf/main.conf

@@ -8,7 +8,6 @@ source $SRC_DIR/modules/debug.sh
 typeset -g URL_REWRITE=0
 typeset -g CGI_ENABLE=0
 typeset -g COMPRESS=0
-typeset -g IP_MATCH=0
 
 typeset -gA URL_PATTERNS
 URL_PATTERNS=( "/file.txt" "/.dot.txt" )
@@ -189,87 +188,3 @@ check 127.0.0.1:$PORT/test_app_fail2.sh \
       --http_code 500
 
 rm $TESTROOT/*.sh
-
-###
-# Finally, test ip match module.
-#
-# Now this is pretty dumb, so hold with me. The IP match module will
-# never reject a connection from localhost. So, in order to test it we
-# try to find a local ip address. If we can't, simply print a warning
-# message instead of crashing our tests.
-case $OSTYPE in
-    (linux*)
-        ip=$(hostname -I | awk '{ print $1 }');;
-    (darwin*|*bsd*)
-        ip=$(ifconfig | awk '$1 == "inet" && $2 != "127.0.0.1" { print $2 }');;
-esac
-
-if [[ -z $ip || ip == "127.0.0.1" ]]; then
-    print "Unable to find suitable IP, skipping IP match tests..."
-    return
-fi
-
-<<EOF > $CONF
-DEBUG=1
-typeset -ga DEBUG_TRACE_FUNCS
-DEBUG_TRACE_FUNCS=($TRACE_FUNCS)
-source $SRC_DIR/modules/debug.sh
-
-URL_REWRITE=0
-COMPRESS=0
-CGI_ENABLE=0
-IP_MATCH=1
-
-source $SRC_DIR/modules/ip_match.sh
-EOF
-reload_conf
-
-describe "Accept all IPs"
-check $ip:$PORT/ \
-      --http_code 200
-
-<<EOF > $CONF
-DEBUG=1
-typeset -ga DEBUG_TRACE_FUNCS
-DEBUG_TRACE_FUNCS=($TRACE_FUNCS)
-source $SRC_DIR/modules/debug.sh
-
-URL_REWRITE=0
-COMPRESS=0
-CGI_ENABLE=0
-
-IP_MATCH=1
-IP_ACCEPT=127.0.0.1
-
-source $SRC_DIR/modules/ip_match.sh
-EOF
-reload_conf
-
-describe "Reject unmatched ip"
-check $ip:$PORT/file.txt \
-      --fail
-
-<<EOF > $CONF
-DEBUG=1
-typeset -ga DEBUG_TRACE_FUNCS
-DEBUG_TRACE_FUNCS=($TRACE_FUNCS)
-source $SRC_DIR/modules/debug.sh
-
-URL_REWRITE=0
-COMPRESS=0
-CGI_ENABLE=0
-
-IP_MATCH=1
-IP_ACCEPT='${ip%.*}.*'
-
-source $SRC_DIR/modules/ip_match.sh
-EOF
-reload_conf
-
-describe "Accept matched ip"
-check $ip:$PORT/file.txt \
-      --http_code 200
-
-describe "Accept localhost"
-check 127.0.0.1:$PORT/file.txt \
-      --http_code 200