-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't be used in ViewPager2 because swipe doesn't work #83
Comments
Try to override onTouch behavior: swipe in normal scale - don't handle it (so view pager can get this event) |
working on getting a fix for this into a snapshot soon |
snapshot is up for this, 1.3.1-SNAPSHOT |
Thanks a lot |
No problem, if you run into issues with it, let me know, otherwise I'll look to get this out of snapshot and into official release in a couple weeks. |
@anthonybattel can you please share the results if you have used this update? |
1.3.1 is in jcenter now |
@usmanrana07 I finally used this library because 1.3.1 zoomage version was not released . You can handle some events this way in Kotlin :
I have not tested 1.3.1 zoomage |
@anthonybattel 1.3.1 version is released now. so, I'm giving it a try as I was using PhotoView before. That too has pretty much rating but in ViewPager2 its scroll was not upto the mark. So, I'm looking for some better library. Anyways thanks for your response. |
Are you still seeing issues scrolling or swiping with 1.3.1? |
If I compare with PhotoView then Zoomage is missing less touches during swipe in a vertical ViewPager2 (means performing better in swipe). But still at some images with need to swipe twice/thrice. Another thing is that we don't have support to override LongPress method. |
Dragging the zoomed image with single finger is not smooth. |
You're having to swipe multiple times with only some images? |
Yes, During swipe it may miss touch at any random images. Not necessarily on same images all the time. |
Unfortunately it doesn't work with ViewPager2. I can zoom in the photo but the ViewPager's swipe is broken so I can't see my next photos in the slideshow.
This library seems to work with but there is no customization like yours
The text was updated successfully, but these errors were encountered: