Rule name changes rollup

[hzoo]

Rule Renames

• requireSpacesInsideObjectBrackets -> requireSpacesInsideObjectBraces requireSpacesInsideObjectBrackets using inconsistent terminology #538
• disallowSpacesInsideObjectBrackets -> disallowSpacesInsideObjectBraces requireSpacesInsideObjectBrackets using inconsistent terminology #538
• disallowMultipleVarDecl -> disallowMultipleVariableDeclaration Should we rename "var" and "decl" rules to "variable" and "declaration" for consistency? #1549
• requireMultipleVarDecl -> requireMultipleVariableDeclaration Should we rename "var" and "decl" rules to "variable" and "declaration" for consistency? #1549
• requireVarDeclFirst -> requireVariableDeclarationFirst Should we rename "var" and "decl" rules to "variable" and "declaration" for consistency? #1549
• requireSpacesInGenerator -> requireSpacesAroundGeneratorStar requireSpacesInGenerator: fix for named functions #1963

---

Remove deprecated values

• disallowMultipleVarDecl - remove legacy option values: strict and exceptUndefined disallowMultipleVarDecl: cleanup #1349
• requireSpaceAfterLineComment - remove legacy option value allowSlash requireSpaceAfterLineComment: drop allowSlash value #697

---

Rework options to use allExcept

• requireCamelCaseOrUpperCaseIdentifiers - change ignoreProperties options to use allExcept Rework ignoreProperties options #1303
• requireDollarBeforejQueryAssignment - change ignoreProperties options to use allExcept Rework ignoreProperties options #1303

---

Newline name consistency #853

• newline or newLine or NewLine, lineBreak, lineFeed, etc

disallowKeywordsOnNewLine
disallowNewlineBeforeBlockStatements
disallowObjectKeysOnNewLine
disallowPaddingNewLinesAfterBlocks
disallowPaddingNewLinesAfterUseStrict
disallowPaddingNewLinesBeforeExport
disallowPaddingNewlinesBeforeKeywords
disallowPaddingNewLinesBeforeLineComments
disallowPaddingNewlinesInBlocks
disallowPaddingNewLinesInObjects
requireBlocksOnNewline
requireKeywordsOnNewLine
requireNewlineBeforeBlockStatements
requireObjectKeysOnNewLine
requirePaddingNewLineAfterVariableDeclaration
requirePaddingNewLinesAfterBlocks
requirePaddingNewLinesAfterUseStrict
requirePaddingNewLinesBeforeExport
requirePaddingNewlinesBeforeKeywords
requirePaddingNewLinesBeforeLineComments
requirePaddingNewlinesInBlocks
requirePaddingNewLinesInObjects
validateNewlineAfterArrayElements

disallowCommaBeforeLineBreak
disallowMultipleLineBreaks
disallowOperatorBeforeLineBreak
requireCommaBeforeLineBreak
requireLineBreakAfterVariableAssignment
requireOperatorBeforeLineBreak
validateLineBreaks

requireLineFeedAtFileEnd

Singular vs. Plural

• ?

Function Spacing rules

• ?
  We should combine/deprecated old ones (require/disallow)
• requireSpacesinFunction
• requireSpacesinFunctionExpression
• requireSpacesinFunctionDeclaration
• requireSpacesinNamedFunctionExpression
• requireSpacesinAnonymousFunctionExpression

spaces around instead of before/after

• requireSpaceAroundBinaryOperators - (require|disallow)SpaceAround* #1476

If not move all the last 4 rules into requiresSpacesInFunction with options, at least remove named/anon and move into functionexpression. Otherwise for any function spacing rule change we need to change 20 files (example is with supporting async)

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[jacksonrayhamilton]

This doesn't have to be breaking; you could define aliases.

[hzoo]

We can do the aliases and then remove in next version yeah.