Spaces in generator declarations/expressions

[geigerzaehler]

If you use generators and JSCS’s esnext option, the behaviour is counter-intuitive.

{
  "esnext": true,
  "requireSpacesInAnonymousFunctionExpression": {
    "beforeOpeningRoundBrace": true
  }
}

var f = function* () {}

This shows the “Missing space before opening round brace“ error. The following doesn’t.

var f = function *() {}

Moreover, with the requireSpaceAfterKeyword option set to true, the following is also an error.

function* f () {}

[qfox]

Yeah, nice idea! Thanks for contributing

[hzoo]

Should this be a bunch of new rules like requireSpacesInGeneratorFunctionExpression? Something similar would be to check the location of the * for

function * ()
function* ()
function *()
function*()

Oh ok there's a similar rule in ESLint http://eslint.org/docs/rules/generator-star-spacing.html

[mikesherov]

right, seperate rule for generator * because they can show up in a few unexpected places.

[qfox]

For me it's pretty close to requireSpacesInConditionalExpression with their afterTest/beforeConsequent: beforeStar, afterStar?

But if we look further and reach ES7's async function * name () we can also try to group up all of them to requireSpacesInFunctionExpression options: beforeAsync, afterAsync. Just a thought.

[hzoo]

Going to at least fix the function spacing rules - we can add the generator spacing rule later.

I guess it since we check beforeRoundBrace then instead of checking function( vs function ( we check *( vs * (

Sorry this could of been done a lot earlier