Skip to content

Commit 675970e

Browse files
committed
fixed all code quality issues
1 parent e28096a commit 675970e

File tree

3 files changed

+13
-4
lines changed

3 files changed

+13
-4
lines changed

pkg/cmd/templateShow.go

+6
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,13 @@ var templateShowCmd = &cobra.Command{
4646
templateDir := os.ExpandEnv(fmt.Sprintf("%s/%s", constants.JRhome, "templates"))
4747
templatePath := fmt.Sprintf("%s/%s.tpl", templateDir, args[0])
4848
templateScript, err := os.ReadFile(templatePath)
49+
if err != nil {
50+
log.Fatalf("Failed to ReadFile: %s", err)
51+
}
4952
valid, err := isValidTemplate([]byte(templateScript))
53+
if err != nil {
54+
log.Fatalf("Failed to read a template: %s", err)
55+
}
5056
templateString := string(templateScript)
5157

5258
var Reset = "\033[0m"

pkg/producers/server/JsonProducer.go

+3
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,9 @@ func (c *JsonProducer) Produce(key []byte, value []byte, o interface{}) {
2121
respWriter := o.(http.ResponseWriter)
2222
if string(key) != "null" {
2323
_, err := (respWriter).Write(key)
24+
if err != nil {
25+
log.Println(err.Error())
26+
}
2427
_, err = (respWriter).Write([]byte(","))
2528
if err != nil {
2629
log.Println(err.Error())

pkg/types/generateRegistry.go

+4-4
Original file line numberDiff line numberDiff line change
@@ -46,14 +46,14 @@ func main() {
4646

4747
var typesList []string
4848
err = filepath.Walk(cwd, func(path string, info os.FileInfo, err error) error {
49-
if !info.IsDir() && isAGoFile(path) && !isAGenerateFile(path) {
49+
if !info.IsDir() && isAGoFile(path) && !isAGenerateFile(path) {
5050
name := strings.Split(filepath.Base(path), ".")
5151

52-
if(! (strings.HasPrefix(name[0], "array_") || strings.HasPrefix(name[0], "map_")) ){
52+
if !(strings.HasPrefix(name[0], "array_") || strings.HasPrefix(name[0], "map_")) {
5353
typesList = append(typesList, name[0])
54-
}else{
54+
} else {
5555
//The naming convention for generated code for Array in gogen-avro is: Array<filename>Wrapper we use Array_<filename>_Wrapper because we use {{camel .}} later in the template
56-
typesList = append(typesList, name[0]+ "_wrapper")
56+
typesList = append(typesList, name[0]+"_wrapper")
5757
}
5858

5959
}

0 commit comments

Comments
 (0)