Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jstachio #127

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add jstachio #127

wants to merge 3 commits into from

Conversation

agentgt
Copy link

@agentgt agentgt commented Dec 14, 2023

I had to backport some automatic stuff we do for Spring Boot 3 because this project is Spring Boot 2 (javax instead of jakarta).

My testing it shows it faster than JSP and the same speed as Rocker. I'm surprised the readme shows Rocker as slower.

BTW the apache tomcat response stream buffer should probably be set higher.

@Vest
Copy link
Collaborator

Vest commented Dec 15, 2023

The project doesn’t cache pages. If you enable caches, you just test the “HashMap” implementation.
maybe that’s is why some frameworks are slower.

@agentgt
Copy link
Author

agentgt commented Dec 15, 2023

The project doesn’t cache pages. If you enable caches, you just test the “HashMap” implementation.
maybe that’s is why some frameworks are slower.

I don't follow nor understand why that matters for the PR.

All I did was follow the readme by building, mvn spring-boot:run and ran the script (which my PR accidentally made a copy of I just noticed... I will delete that later today).

It should not be surprising that Rocker or JStachio "might" run faster "on my machine" than JSP as they do the same thing: compile to Java.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants