Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vimeo links can have a second path segment which brakes the embed #24

Open
SanBen opened this issue Feb 25, 2022 · 3 comments
Open

Vimeo links can have a second path segment which brakes the embed #24

SanBen opened this issue Feb 25, 2022 · 3 comments

Comments

@SanBen
Copy link

SanBen commented Feb 25, 2022

Video links that are exposed in certain share dialogs of Vimeo can have two path segments, this breaks the embed.
It seems this happens with private videos that are exposed via a "share" link.

Paste this: https://vimeo.com/680825358/fd410b0271 into the video url field of "statamic-video-embed"

Current behaviour:
breaks because it takes the last path segment even though it should take the first

Expected behaviour:
works because it takes the first path segment

@jcohlmeyer
Copy link
Member

I do not I will be updating the V2 version of this plugin anymore as V3 has been out for a while, however, if you want to take a stab at it you can send a pull request.

The code would need to be updated to get the video ID in these two places:

https://github.com/jrc9designstudio/statamic-video-embed/blob/master/resources/assets/js/fieldtype.js#L73
https://github.com/jrc9designstudio/statamic-video-embed/blob/master/VideoEmbed.php#L37

@SanBen
Copy link
Author

SanBen commented Mar 27, 2022

I do not I will be updating the V2 version of this plugin anymore as V3 has been out for a while, however, if you want to take a stab at it you can send a pull request.

The code would need to be updated to get the video ID in these two places:

https://github.com/jrc9designstudio/statamic-video-embed/blob/master/resources/assets/js/fieldtype.js#L73 https://github.com/jrc9designstudio/statamic-video-embed/blob/master/VideoEmbed.php#L37

Ok that makes sense, but where is V3? It is not listed in the addons section and I can't seem to find it on GitHub either.

@jcohlmeyer
Copy link
Member

Yes, I have not yet ported it to V3. As there is now a native video field I was not sure there was much demand for this anymore. However I am planning on working on a new version for Statamic V3, I am just not sure about the timeline for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants