Fix bug where job deploys with count 0 hang. #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jobs with count 0 do not produce deployments and therefore when performing a deployment with a count of zero Levant would hang attempting to track a deployment which would never occur. This introduces a checker to see whether the job has any taskgroups with a count greater than zero. Closes #243
|
@mdcollins05 sorry for the delay but this should fix the issue you raised. I'll get this merged and released tomorrow. |
|
Awesome! Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jobs with count 0 do not produce deployments and therefore when
performing a deployment with a count of zero Levant would hang
attempting to track a deployment which would never occur. This
introduces a checker to see whether the job has any taskgroups
with a count greater than zero.
Closes #243