Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: share queue/browser handling for all worker types #5465

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

timmywil
Copy link
Member

@timmywil timmywil commented Apr 1, 2024

Summary

3.x version of #5460

  • one queue to rule them all: browserstack, selenium, and jsdom
  • retries and hard retries are now supported in selenium
  • selenium tests now re-use browsers in the same way as browserstack

Sample test run to make sure nothing broke: https://github.com/timmywil/jquery/actions/runs/8509342926

Checklist

- one queue to rule them all: browserstack, selenium, and jsdom
- retries and hard retries are now supported in selenium
- selenium tests now re-use browsers in the same way as browserstack
@timmywil timmywil requested a review from mgol April 1, 2024 14:35
@timmywil timmywil added the Tests label Apr 1, 2024
@timmywil timmywil added this to the 3.7.2 milestone Apr 1, 2024
Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming it's the same as the main version

@timmywil
Copy link
Member Author

timmywil commented Apr 1, 2024

yes, the commit was cherry-picked.

@timmywil timmywil merged commit cc44f76 into jquery:3.x-stable Apr 1, 2024
11 checks passed
@timmywil timmywil deleted the runner-3.x branch April 1, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants