Tests: share queue/browser handling for all worker types #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmywil
force-pushed
the
queue
branch
2 times, most recently
from
12e57b3
to
8bec395
Compare
|
For the record, I reviewed most of this PR by doing a directory diff on the jQuery version of |
- one queue to rule them all: browserstack and selenium - retries and hard retries are now supported in selenium - selenium tests now re-use browsers in the same way as browserstack Close jquerygh-508
|
I'm going to keep the separate commits by rebasing, but I've added a reference in each commit message to this PR. |
timmywil
added a commit
that referenced
this pull request
Apr 4, 2024
timmywil
added a commit
that referenced
this pull request
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR for jquery/jquery#5460 and jquery/jquery#5465
Sample test runs
3.x: https://github.com/timmywil/jquery-migrate/actions/runs/8548231361
git: https://github.com/timmywil/jquery-migrate/actions/runs/8548231364