You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 11, 2021. It is now read-only.
CSS best practices have changed a bit since we started this project. Along that line I think we should review how we've done typography so far in this project and how we can best refactor it to match best standards. Specifically there is a lot of px useage for size/measurements, and we have a em convertor when we could probably be using rem instead. Same thing holds true with a lot of measurements for components that have been created - overuse of the px measurement unit.
The text was updated successfully, but these errors were encountered:
We have used em for typography. Can't we used rem for that instead of em? Wouldn't that prove good?
According to me using em would cause problems when 2-3 elements are nested.For example nested unordered lists. Opinions?
@sfrisk I am refactoring typography. I want to use rem instead of em. The _typography.scss file has all the values of typography defined in pixels....shall I keep them in pixels as it is? Since the pixel to rem converting function will take care of final conversion to rem format.
check out https://www.youtube.com/watch?v=XanhwddQ-PM - this shows a lot of the techniques we were planning on applying to typography, and unit measurement in general for Chassis.
CSS best practices have changed a bit since we started this project. Along that line I think we should review how we've done typography so far in this project and how we can best refactor it to match best standards. Specifically there is a lot of px useage for size/measurements, and we have a em convertor when we could probably be using rem instead. Same thing holds true with a lot of measurements for components that have been created - overuse of the px measurement unit.
The text was updated successfully, but these errors were encountered: