Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1649 multiple resources #2165

Closed
wants to merge 6 commits into from

Conversation

jimhlad
Copy link

@jimhlad jimhlad commented Apr 6, 2022

Continued from here (ported the functionality and made some adjustments): #1724

Per #1649 , this adds support for events linked to multiple resources.

The example code has been updated to demonstrate two possible drag and drop behaviours:

  1. Copy - By dragging an event into a different resource lane, the event gets assigned to both resources.
  2. Move - By dragging an event into a different resource lane, the event is removed from the source resource and added to the target resource.

Please see stories/demos/exampleCode/dndresource.js for an example.

Fixes #1649

@jimhlad jimhlad mentioned this pull request Apr 6, 2022
@jimhlad
Copy link
Author

jimhlad commented Apr 8, 2022

@cutterbl Let me know if anything else is needed here.

Happy to make any changes needed to get this integrated.

@cutterbl
Copy link
Collaborator

@jimhlad I haven't had time to thoroughly review the changes yet, but I did notice that there weren't any changes to the stories to explain the change in behavior.

@jimhlad
Copy link
Author

jimhlad commented Apr 11, 2022

@cutterbl Thanks for reviewing.

Just modified stories/DragAndDrop.stories.js to show an example of the calendar with multi-resource events. Let me know if this is what you were referring to?

A more detailed example can be found here: stories/demos/exampleCode/dndresource.js.

@cutterbl
Copy link
Collaborator

@jimhlad That's part of it, but also some explanation in the documentation. Maybe something in the resources prop documentation?

@cutterbl
Copy link
Collaborator

cutterbl commented Feb 9, 2023

@jimhlad Can you please update your branch with latest changes to 'master' for testing please? As well as add some documentation? Think this would be a great feature.

@basstager
Copy link
Contributor

@cutterbl As this is quite a nice feature, desired by our team as well I opened a new PR (#2405) with an update from master and some minor documentation updates.

@cutterbl
Copy link
Collaborator

cutterbl commented Jun 2, 2023

Code moved to #2405 and released as part of v1.7.0

@cutterbl cutterbl closed this Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple resources per event
3 participants