Default color of jq is indistinguishable under Solarized Light background

[taoky]

Describe the bug
Since jq 1.7, its default color is very hard to read when using Solarized Light.

To Reproduce

Tilix 1.9.5, with Solarized Light color scheme.

> echo '{"a": 1, "b": "b", "c": [1,2,3,4,5]}' | jq .

Expected behavior

Clean output like jq 1.6.

Environment (please complete the following information):

• OS and Version: Arch Linux
• jq version 1.7

Additional context

This may be caused by #2824.

[itchyny]

#2824 does not change the color of numbers. Could you share the screenshot of the same command with jq 1.6?

[taoky]

jq 1.6:

I'm also bisecting jq's code and I would comment here if I have found out that commit.

[taoky]

It's 07b18a3.

[taoky]

This works correctly within Solarized Light:

> echo '{"a": 1, "b": "b", "c": [1,2,3,4,5]}' | JQ_COLORS="1;30:0;39:0;39:0;39:0;32:1;39:1;39" jq .

(Screenshot is the same as jq 1.6).

Guess that this commit should be reverted...

[taoky]

I'm trying to revert this commit, and it seems that directly changes "37" to "39" will make "null" indistinguishable under dark background. "null" also shows badly in released jq 1.7 under Solarized Dark.

[nicowilliams]

It might be nice to have an env var that names the terminal's color scheme so we can pick a suitable color scheme.

[taoky]

It might be nice to have an env var that names the terminal's color scheme so we can pick a suitable color scheme.

It's a bit mess as there's no universal convention about getting color scheme: https://unix.stackexchange.com/questions/245378/common-environment-variable-to-set-dark-or-light-terminal-background.

[nicowilliams]

It might be nice to have an env var that names the terminal's color scheme so we can pick a suitable color scheme.

It's a bit mess as there's no universal convention about getting color scheme: https://unix.stackexchange.com/questions/245378/common-environment-variable-to-set-dark-or-light-terminal-background.

Using COLORFGBG sounds pretty good to me. I'm not too keen on OSC 11 because that would be the first instance in which jq communicates with the terminal, and I'd rather not have that complexity since we can leave it to shell-term-background to set COLORFGBG where OSC 11 is supported and tell people to use that.