-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not vertically centered #70
Comments
I'll take a look at the vertical metrics to see if anything is wrong. Adding to my TODOs. |
I have fixed this with these metrics in the 1.5 branch https://github.com/jpt/barlow/tree/1.5
I may need to add some uniform padding to top and bottom to match the previous release in Google Fonts, so that the line height doesn't change. I will check. |
Wow that's great to hear! I really appreciate it. I'll try and see if the things vertically align with 1.5 |
I've generated some binaries, let me know if this solves it: https://github.com/jpt/barlow/tree/1.5/fonts if it does, I may still change vertical metrics between now and release of 1.5, but that's the general approach I'd use (centering on captial letters) |
Hello @jpt, we love Barlow! |
@Mattia-Marchiorato Seems like this isn't even close to ready, I love this font too but it seems @jpt is busy with other projects telling by his GH activity. |
@applecuckoo so sad 😔 |
take a look at https://github.com/jpt/barlow/archive/refs/heads/1.5.zip |
@jpt's comment definitely fixes it! Would this fix also be possible on the Mono font? 🙏 |
My team is using this font in a web app and I noticed I couldn't vertically align icons with the text. I eventually realized it was the font itself.
Switching between Arial and Barlow:

After some googling I found this twitter thread:
https://twitter.com/jocelyncaronfr/status/1194205393553121286
https://twitter.com/jeremytribby/status/1194712659116998656
We are hesitant to add negative margin to our components to vertically center as Jeremy suggests because if we ever change fonts we'll have 1px offsets everywhere adding a bunch of technical debt.
Pardon my ignorance about fonts, but is it possible to have equal margin on both sides and still support Vietnamese? Otherwise is it possible to have a variant that supports equal margin?
Thanks in advance!
The text was updated successfully, but these errors were encountered: