Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template globals might be leaking between threads #106

Closed
jodal opened this issue Feb 25, 2025 · 1 comment
Closed

Template globals might be leaking between threads #106

jodal opened this issue Feb 25, 2025 · 1 comment
Assignees
Labels

Comments

@jodal
Copy link
Contributor

jodal commented Feb 25, 2025

I'm not entirely certain about this, but since I have a hunch this is causing the issues I'm seeing and the consequences might be serious, I want to report it sooner rather than later.

Looking at issue #89 and PR #90 where collected CSS and JS leaks from one template render to another, I suspect the same happens to Catalog._tmpl_globals, which has exactly the same usage pattern as collected_css and collected_js.

If one uses the template globals to pass e.g. the request object to components, this can cause serious issues, where templates are rendered based on the request objects belonging to different users.

@jpsca jpsca self-assigned this Mar 12, 2025
@jpsca jpsca added the triage label Mar 12, 2025
@jpsca
Copy link
Owner

jpsca commented Mar 13, 2025

It was. Thank you for the report. It's fixed in the latest release

@jpsca jpsca closed this as completed Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants