Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comparison with lerna #160

Closed
threepointone opened this issue Nov 23, 2020 · 0 comments
Closed

comparison with lerna #160

threepointone opened this issue Nov 23, 2020 · 0 comments
Labels
discussion Discussion topic

Comments

@threepointone
Copy link
Contributor

threepointone commented Nov 23, 2020

This issue is a discussion for what additional functionality we'd need in modular. I took the list of commands from lerna, and added some notes for how it relates to us. I didn't dive into specific options passed to these commands.


🤔 version, diff, publish: I'm not sure we should have a parallel for these in modular. We're not in the business of only making packages, but apps as well, which don't really get published to a registry (and instead would get deployed to a server, maybe). What we will do with build is generate artifacts (for libs and apps) that can then be deployed to wherever. Until we figure out a blessed release process, let's hold off on these.

bootstrap, link: Accomplished with running yarn in the root.

🤔 list: This could be useful, but I'd like for us to think about this more. I'm thinking we could make a dashboard application that does way more than this; list all applications and libraries grouped correctly, UI for running tasks like tests, insight into running processes etc.

changed: This would be useful for running build --changed. Related issue: #147

🤔 exec: This would be useful, but really it'll be a patch on missing functionality from yarn/yarn workspaces run. 50/50 on this.

init: Accomplished with yarn create modular-react-app

add: Instead, use yarn add directly in workspaces/root.

clean: This is useful, we should probably do this anyway.

🤔 import: I'm... not so sure about this. Maybe. Let's do it if the need arises.

create: Accomplished with what we call 'modular add '

info: We could do this, useful for bug reports.

@threepointone threepointone added the discussion Discussion topic label Nov 23, 2020
@jpmorganchase jpmorganchase locked and limited conversation to collaborators May 24, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
discussion Discussion topic
Projects
None yet
Development

No branches or pull requests

2 participants