-
Notifications
You must be signed in to change notification settings - Fork 7.3k
added additional properties to getPeerCertificate #1286
Conversation
Added additional properties to getPeerCertificate, now includes subjectAltName, Exponent and Modulus (FOAF+SSL friendly). Patch written by Nathan, http://groups.google.com/group/nodejs/browse_thread/thread/1d42da4cb2e51536
If Nathan == Nathan Rixham, we need him to sign the CLA first. My two points from the ML thread also still stand.
|
Oh okay. Is there any contact to Nathan? I just saw the patch on google groups and wondered why it isn't merged yet. |
Maybe revive the ML thread? |
BIO* bio = BIO_new(BIO_s_mem()); | ||
BIO* bio = NULL; | ||
ASN1_OBJECT *oid; | ||
oid = OBJ_txt2obj("2.5.29.17", 1); // OID 2.5.29.17 is Subject AltName |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just use the NID_subject_alt_name instead of an OID?
https://github.com/pquerna/selene/blob/master/lib/core/certs.c#L427-458
I wrote to Nathan, but still no reply from him :( There is no chance to get this into node if Nathan doesn't sign the CLA right? I'll open an issue for that, maybe someone can look into this, so we don't need him to sign the CLA. |
Closing. We can't take the patch without a signed CLA. |
Nathan has now signed the CLA, any chance to reopen this issue? |
Reopened. I'll merge it when I have time to write a few tests for it (hint, hint). |
Added additional properties to getPeerCertificate, now includes
subjectAltName, Exponent and Modulus (FOAF+SSL friendly).
Patch written by Nathan,
http://groups.google.com/group/nodejs/browse_thread/thread/1d42da4cb2e51536