The timers' ms arg should be an integer

[xk]

setTimeout() / setInterval() do strange things when it isn't.

[felixge]

Patch LGTM.

What strange things did you observe?

Anyway, I just tested and setTimeout seems to accept timeouts as strings in the browser, so doing it the same in node is probably a good idea.

[xk]

The weird thing that happens when passing a float is that it takes longer to fire than expected. This demonstrates the problem https://gist.github.com/932844

You can pass strings:
[Math.floor('3.14'), typeof Math.floor('3.14')] -> [ 3, 'number' ]

[isaacs]

Seems like the Bad Thing happens when passing in a number between 0 and 1. JS doens't have sub-millisecond precision anyhow, so flooring is the right thing to do.

[ry]

i don't think there is any problem. we already take the IntegerValue in the binding.

[isaacs]

@ry: Somehow it ends up doing a setTimeout for 1000 when provided a number between 0 and 1. Try it:

var t = Date.now()
setTimeout(function () {
  console.error(Date.now() - t)
}, 0.1)

When provided with a float greater than 1, it works as expected.

[ry]

ah okay. then it is a bug in the binding and should be fixed there. test should be added too.