This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I was trying to subclass REPLServer to not share a context across instances. It turns out there's no way to do this conveniently because the current REPL implementation refers to a global
context
variable in several places. This patch does the following:this.context
orself.context
instead ofcontext
.resetContext
toREPLServer.createContext
.REPLServer.resetContext
, memoizecontext
here.exports.repl
instart
instead of REPLServer constructor.My use case is a local "administration" REPL for a web service. If several people are connected to the REPL, I don't want their context shared because they may clobber each others bindings by defining variables with the same name or using ".clear".
With this patch, the following works as expected (each repl has a unique local context):