Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Diffie-Hellman support in crypto module #573

Closed
wants to merge 4 commits into from
Closed

Conversation

havard
Copy link

@havard havard commented Jan 22, 2011

I've implemented Diffie-Hellman support in the crypto module, utilizing OpenSSL. Would you consider the patch for inclusion? I am uncertain as to whether you require more information than this pull request. If so, please let me know.

@ry
Copy link

ry commented Jan 27, 2011

Can you add a test?

@havard
Copy link
Author

havard commented Feb 7, 2011

Let me know if you need anything else.

@ry
Copy link

ry commented Feb 7, 2011

Sorry, can you please fix the style. In particular the long lines:

python tools/cpplint.py src/node_crypto.cc

Please start with this patch: https://gist.github.com/815320

  • I removed the addition to AUTHORS, which we do when we bump the version
  • Rebased to master
  • fixed the long lines in the docs

@havard
Copy link
Author

havard commented Feb 8, 2011

Same commit as patch ready for application on top of your rebased patch: https://gist.github.com/817133. Or, you can cherry-pick the last commit (which was cherry-picked onto master from a branch started from your rebased patch).

@ry ry closed this in 9f0b1a9 May 6, 2011
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants