Node shouldn't swallow SSL certificate error #2246
Comments
|
Hi, I just upgraded to 0.6.5 and am still seeing the same problem. With an incorrect private key, the ssl connection fails, but no message is dumped to stderr. |
|
@georgesnelling: Can you post a test case? |
|
Will do, might take a day or two to trim down |
|
@piscisaureus. Can you help me understand why you opened this issue instead of just letting me do it? Do you know something about the area, or do you play some sort QA role for the core team, or were you just saving me the trouble? If it's the latter I'd prefer to open it myself so that I can keep track of it. But if there is any other reason I'm happy to keep the trail here. Thanks, |
|
I went ahead and opened #2308 so that I'll remember to follow up on this one. You can close this if you like. Thanks Bert. |
|
Fixed in 29b1fdd. |
|
@piscisaureus Oops, koichik/node@29b1fdd has not been merged yet. . Can you review? |
|
@koichik: LGTM |
|
@bnoordhuis Thanks! |
* Upgrade V8 to 3.6.6.15 * Upgrade npm to 1.1.0-beta-10 (isaacs) * many doc updates (Ben Noordhuis, Jeremy Martin, koichik, Dave Irvine, Seong-Rak Choi, Shannen, Adam Malcontenti-Wilson, koichik) * nodejs#2438 segfault in node v0.6.6 * dgram, timers: fix memory leaks (Ben Noordhuis, Yoshihiro Kukuchi) * repl: fix repl.start not passing the `ignoreUndefined` arg (Damon Oehlman) * nodejs#1980: Socket.pause null reference when called on a closed Stream (koichik) * nodejs#2263: XMLHttpRequest piped in a writable file stream hang (koichik) * nodejs#2069: http resource leak (koichik) * buffer.readInt global pollution fix (Phil Sung) * timers: fix performance regression (Ben Noordhuis) * nodejs#2308, nodejs#2246: node swallows openssl error on request (koichik) * nodejs#2114: timers: remove _idleTimeout from item in .unenroll() (James Hartig) * nodejs#2379: debugger: Request backtrace w/o refs (Fedor Indutny) * simple DTrace ustack helper (Dave Pacheco) * crypto: rewrite HexDecode without snprintf (Roman Shtylman) * crypto: add SecureContext.clearOptions() method (Ben Noordhuis) * crypto: don't ignore DH init errors (Ben Noordhuis)
* V8 hash collision fix (Breaks MIPS) (Bert Belder, Erik Corry) * Upgrade V8 to 3.6.6.15 * Upgrade npm to 1.1.0-beta-10 (isaacs) * many doc updates (Ben Noordhuis, Jeremy Martin, koichik, Dave Irvine, Seong-Rak Choi, Shannen, Adam Malcontenti-Wilson, koichik) * Fix segfault in node_http_parser.cc * dgram, timers: fix memory leaks (Ben Noordhuis, Yoshihiro Kukuchi) * repl: fix repl.start not passing the `ignoreUndefined` arg (Damon Oehlman) * #1980: Socket.pause null reference when called on a closed Stream (koichik) * #2263: XMLHttpRequest piped in a writable file stream hang (koichik) * #2069: http resource leak (koichik) * buffer.readInt global pollution fix (Phil Sung) * timers: fix performance regression (Ben Noordhuis) * #2308, #2246: node swallows openssl error on request (koichik) * #2114: timers: remove _idleTimeout from item in .unenroll() (James Hartig) * #2379: debugger: Request backtrace w/o refs (Fedor Indutny) * simple DTrace ustack helper (Dave Pacheco) * crypto: rewrite HexDecode without snprintf (Roman Shtylman) * crypto: don't ignore DH init errors (Ben Noordhuis)
Reported here: http://groups.google.com/group/nodejs/msg/66cd09d4eccffa2d
The text was updated successfully, but these errors were encountered: