npm download not working in unix with NODE_USE_UV=1

[ry]

e.g. npm install socket.io failes

cc @isaacs

[bnoordhuis]

Possibly related to #1531.

[mikeal]

@isaacs fixed this on the npm side

[isaacs]

I'm pretty sure that this issue was a result of 7e32ef571d15bf40723725c0c0a86be7a16d7cfa. Fixed both in npm and in node.

[ry]

@isaacs, that hasn't been landed yet. what's the fix in npm? npm should not conform to node's bugs as we switch backends.

[mikeal]

@isaacs you know what, i was thinking of that host header issue that we fixed in the last release, nevermind.

[ry]

#1531 did not fix.

[mikeal]

what is the actual exception for this npm issue?

[isaacs]

Ah, weird. On node 0.5.3, running NODE_USE_UV=1 npm install socket.io -dd doesn't trigger any output at all (as if process.stdout.write is somehow broken?), and the resulting npm-debug.log file shows:

ERR! TypeError: Cannot call method 'readStart' of null
ERR!     at Socket.resume (net_uv.js:163:16)
ERR!     at Socket.<anonymous> (util.js:423:16)
ERR!     at Socket.emit (events.js:64:17)
ERR!     at Object.afterWrite [as oncomplete] (net_uv.js:381:10)
ERR! Report this *entire* log at:
ERR!     <https://github.com/isaacs/npm/issues>
ERR! or email it to:
ERR!     <[email protected]>
ERR! 
ERR! System Darwin 10.8.0
ERR! command "node" "/Users/isaacs/local/bin/npm" "install" "socket.io" "-ddd"
ERR! cwd /Users/isaacs/private/writing/node-blog
ERR! node -v v0.5.3
ERR! npm -v 1.0.26

[ry]

Found the error. NPM uses new net.Stream(fd).

We need to add compatibility for this API. In the meantime I've changed Node to throw when people attempt this constructor.

e3413f0

Note that NPM has a

• try { .. } catch() {} around log statements,
• a buffered log which calls itself recursively,
• and an uncaughtException handler which enters the log
  these combine in horrible ways to mask this new error that I've added.

Added #1573 for constructor on fd support.

[isaacs]

try { .. } catch() {} around log statements,

Not around log statements, around the creation of the stream. If it fails, no stream gets created, which is why there's zero output at all. The npm-debug.log file still showed the failure, though.

Updated to use process.stdout and process.stderr if the supplied FD matches theirs. To still trigger the error, do this:

# expected, pre-uv:
$ npm install socket.io --outfd 3 3>out.txt ; cat out.txt
[email protected] ./node_modules/socket.io 
├── [email protected]
├── [email protected]
└── [email protected]

# actual: no output
$ NODE_USE_UV=1 npm install socket.io --outfd 3 3>out.txt ; cat out.txt

$ ls -laF out.txt
-rw-r--r--  1 isaacs  staff  0 Aug 23 09:25 out.txt

a buffered log which calls itself recursively,

It only buffers until the config files are read and processed, since before that time, it doesn't know which logs you want shown, and I write a few verbose logs saying which config files are getting loaded. Updated to remove the uncaughtException handler and throw if there's an error prior to ini resolution.

• and an uncaughtException handler which enters the log

It seems that removing an uncaughtException handler doesn't put node back in a state where throws are logged. So, if there's an early termination where it's not clear that the log will work (ie, exit prior to resolving the configs) then it'll write to console.error, and exit.

[ry]

downloads working as of ef523e5