Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

EV_MULTIPLICITY: node vs add-ons #1229

Closed
bnoordhuis opened this issue Jun 25, 2011 · 2 comments
Closed

EV_MULTIPLICITY: node vs add-ons #1229

bnoordhuis opened this issue Jun 25, 2011 · 2 comments

Comments

@bnoordhuis
Copy link
Member

Current master appears to be compiled with EV_MULTIPLICITY and that breaks add-ons at run-time because node-waf passes EV_MULTIPLICITY=0 to g++.

I say at run-time because the add-on compiles fine but crashes when it invokes an ev_*() function that expects a loop pointer as its first argument, like ev_io_start() (it interprets the watcher object as a loop object).

@swick
Copy link

swick commented Jun 25, 2011

it seems like that the segmentation fault only occurs when using fcntl on the descriptor.
https://gist.github.com/1046893

@mscdex
Copy link

mscdex commented Jul 14, 2011

I think I may be running into this issue as well with node-ncurses, although commenting out my calls to fcntl() doesn't help any in my case. Is there a fix for this we can apply, or at least some kind of ifdef blocks to make it work for both node 0.4.x and 0.5.x?

EDIT: nevermind, found the fix.

@ry ry closed this as completed in 6128757 Jul 14, 2011
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants